Bug 1017

Summary:	node --> internet-stack --> node
Product:	ns-3	Reporter:	Gustavo J. A. M. Carneiro <gjcarneiro>
Component:	general	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tomh, watrous
Priority:	P5
Version:	ns-3-dev
Hardware:	All
OS:	All

Description Gustavo J. A. M. Carneiro 2010-10-26 06:45:11 UTC

[367/515] cxx: src/node/ipv6-packet-info-tag.cc -> build/debug/src/node/ipv6-packet-info-tag_1.o
../src/node/ipv6-packet-info-tag.cc:148: fatal error: ns3/internet-stack-helper.h: No such file or directory
compilation terminated.
../src/node/ipv4-packet-info-tag.cc:150: fatal error: ns3/internet-stack-helper.h: No such file or directory
compilation terminated.
Waf: Leaving directory `/home/gjc/projects/ns/ns-3-allinone/ns-3-dev-clean/build'

node --> internet-stack (helper) --> node: circular dependency, this is bad...

Comment 1 Mitch Watrous 2010-11-01 15:28:40 UTC

Would this be solved by putting the following modules into a lowest level module that doesn't depend on any other modules:

    common
    core
    node
    helper

Comment 2 Gustavo J. A. M. Carneiro 2010-11-07 18:59:56 UTC

(In reply to comment #1)
> Would this be solved by putting the following modules into a lowest level
> module that doesn't depend on any other modules:

No, I think in this case this dependency happens only because of a test suite code that is included at the end of src/node/ipv6-packet-info-tag.cc.  I think this test suite code should be to a separate program, and should also not depend on the internet-stack module.  It makes no sense that you cannot test the 'node' module without the presence of the 'internet-stack' module above it.

Comment 3 Tom Henderson 2011-02-25 14:44:32 UTC

fixed in 036f9a0b9899