Bug 1019

Summary:	common --> node --> common circular dependency
Product:	ns-3	Reporter:	Gustavo J. A. M. Carneiro <gjcarneiro>
Component:	general	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	watrous
Priority:	P5
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	proposed patch

Description Gustavo J. A. M. Carneiro 2010-10-26 10:09:14 UTC

src/common/propagation-loss-model.cc:

void
MatrixPropagationLossModel::SetLoss (Ptr<Node> a, Ptr<Node> b, double loss, bool symmetric)

Comment 1 Gustavo J. A. M. Carneiro 2010-10-31 11:13:23 UTC

And of course #include "ns3/node.h" in src/common/propagation-loss-model.h.  This is blocking my modular Python bindings work.

Comment 2 Mitch Watrous 2010-11-01 15:31:01 UTC

Would this be solved by putting the following modules into a lowest level
module that doesn't depend on any other modules:

    common
    core
    node
    helper

Comment 3 Gustavo J. A. M. Carneiro 2010-11-07 19:03:09 UTC

(In reply to comment #2)
> Would this be solved by putting the following modules into a lowest level
> module that doesn't depend on any other modules:
> 
>     common
>     core
>     node
>     helper

A simpler option in this case is to change the signature of the method from:


    MatrixPropagationLossModel::SetLoss (Ptr<Node> a, Ptr<Node> b, double loss,
bool symmetric)

to:


    MatrixPropagationLossModel::SetLoss (Ptr<Object> a, Ptr<Object> b, double loss,
bool symmetric)

Comment 4 Tom Henderson 2010-11-09 23:08:45 UTC

Created attachment 1011 [details]
proposed patch

Comment 5 Mitch Watrous 2011-01-20 16:32:39 UTC

Bug closed.

ns-3-dev changeset: bb040260d75c