|
Bugzilla – Full Text Bug Listing |
| Summary: | replace virtual method with callbacks | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Andrey Churin <aachurin> |
| Component: | network | Assignee: | ns-bugs <ns-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mathieu.lacage |
| Priority: | P5 | ||
| Version: | ns-3-dev | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | patch to replace virtual method with callbacks | ||
|
Description
Andrey Churin
2011-03-07 08:12:10 UTC
(In reply to comment #0) > virtual method NotifyDeviceAdded really should be private? Perhaps it would be > better to make it protected? a private virtual method can be overriden by subclasses to get the event so, not, it should not be protected. However, this code is really old and comes from the Node-as-base-class design we had a long time ago. I have been using the attached patch for a while so, I committed it together with a removal of the virtual keyword. Created attachment 1191 [details]
patch to replace virtual method with callbacks
changeset e440347eff27 |