|
Bugzilla – Full Text Bug Listing |
| Summary: | Useless assignment in omnet-data-output.cc | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Quincy Tse <quincy.tse> |
| Component: | general | Assignee: | Mitch Watrous <watrous> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | CC: | tomh |
| Priority: | P5 | ||
| Version: | ns-3-dev | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: |
Patch that silents both unused variable and useless assignment warnings.
Updated patch |
||
Created attachment 1082 [details]
Updated patch
Patched code now recognises the following number format:
[-][\d]*[.[\d]*][e[-][\d]*[.[\d]*]]
(note - will accept "-", ".", "e" , "e.", etc as well)
Bug closed. ns-3-dev changeset: 4e1d562d5029 |
Created attachment 1081 [details] Patch that silents both unused variable and useless assignment warnings. src/stats/model/omnet-data-output.cc, in the function isNumeric, contains "useless" assignment (to silent compiler warning regarding unused variable). This causes warnings when the compiler is set to check for useless assignments. Attached patch uses different code that avoids the use of this variable, and is slightly more verbose, but may not cover the entire range of inputs.