Bug 1143

Summary:	CsmaStarHelper::GetHubDevices() returns spoke devices, not hub devices
Product:	ns-3	Reporter:	Shane Tuohy <slibuntu>
Component:	helpers	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	john.abraham.in, tomh
Priority:	P5
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	Fix for bug, replaces m_spokeDevices with m_hubDevices

Description Shane Tuohy 2011-05-13 12:26:06 UTC

Created attachment 1113 [details]
Fix for bug, replaces m_spokeDevices with m_hubDevices

Title says it all, the problem is shown below. This is my first bug/fix submission, so if I have made a mistake, please let me know.

NetDeviceContainer
CsmaStarHelper::GetHubDevices () const
{ 
  return m_spokeDevices;
}

NetDeviceContainer
CsmaStarHelper::GetSpokeDevices () const
{ 
  return m_spokeDevices;
}


Fix diff is attached

Comment 1 John Abraham 2011-05-16 12:50:21 UTC

(In reply to comment #0)
> Created attachment 1113 [details]
> Fix for bug, replaces m_spokeDevices with m_hubDevices
> 
> Title says it all, the problem is shown below. This is my first bug/fix
> submission, so if I have made a mistake, please let me know.
> 
> NetDeviceContainer
> CsmaStarHelper::GetHubDevices () const
> { 
>   return m_spokeDevices;
> }
> 
> NetDeviceContainer
> CsmaStarHelper::GetSpokeDevices () const
> { 
>   return m_spokeDevices;
> }
> 
> 
> Fix diff is attached

The following changeset ought to address this
http://code.nsnam.org/ns-3-dev/rev/08ae7db938f6