Bug 1242

Summary:	m_lastRtt in tcp-socket-base.cc is not implemented
Product:	ns-3	Reporter:	John Abraham <john.abraham.in>
Component:	tcp	Assignee:	Adrian S.-W. Tam <adrian.sw.tam>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ns-bugs
Priority:	P5
Version:	pre-release
Hardware:	All
OS:	All

Description John Abraham 2011-08-10 06:15:35 UTC

proposed diff

--- a/src/internet/model/tcp-socket-base.cc     Mon Aug 08 08:33:29 2011 
-0700 
+++ b/src/internet/model/tcp-socket-base.cc     Wed Aug 10 06:00:43 2011 
-0400 
@@ -1453,7 +1453,7 @@ 
   // Use m_rtt for the estimation. Note, RTT of duplicated 
acknowledgement 
   // (which should be ignored) is handled by m_rtt. Once timestamp 
option 
   // is implemented, this function would be more elaborated. 
-  m_rtt->AckSeq (tcpHeader.GetAckNumber () ); 
+  m_lastRtt = m_rtt->AckSeq (tcpHeader.GetAckNumber () ); 
 };

Comment 1 Adrian S.-W. Tam 2011-09-29 13:17:07 UTC

This is valid. This patch shall be accepted.