Bug 1287

Summary:	feature request: patch generation tool
Product:	ns-3	Reporter:	Tom Henderson <tomh>
Component:	general	Assignee:	ns-bugs <ns-bugs>
Status:	NEW ---
Severity:	enhancement
Priority:	P5
Version:	pre-release
Hardware:	All
OS:	All

Description Tom Henderson 2011-11-03 11:50:14 UTC

a recent post on the mailing list about generating patches for review got me thinking that it may be useful to include a program in utils/ that would generate a properly formatted patch against ns-3-dev, passing all the right --exclude flags to exclude build/ .hg/ bindings/ directories.

for instance, something like 
utils/generate-patch.sh

could do an hg clone of ns-3-dev in some temporary directory, run the diff properly, and clean up after itself, leaving a patch named such as diff-against-<changeset>.patch

it could be extended to allow users to pass other options such as -r <repository> (if not ns-3-dev), -n <name-of-patch>, etc.

Comment 1 Tommaso Pecorella 2012-02-29 18:18:49 UTC

In my nightly buglist checks to see if I can fix something, I stumbled on this one.

I think it's safe to Downgrade it to enhancement (it's a feature request indeed).

On the other hand, out of curiosity: isn't upload.py already doing something similar ? 

T.

Comment 2 Tom Henderson 2012-02-29 22:41:37 UTC

(In reply to comment #1)
> In my nightly buglist checks to see if I can fix something, I stumbled on this
> one.
> 
> I think it's safe to Downgrade it to enhancement (it's a feature request
> indeed).
> 
> On the other hand, out of curiosity: isn't upload.py already doing something
> similar ? 

Yes, if the target is to upload to Rietveld (which it not always is)