|
Bugzilla – Full Text Bug Listing |
| Summary: | Please exclude headers for tests from installation | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Vedran Miletić <vedran> |
| Component: | lte | Assignee: | Nicola Baldo <nicola> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | manuel.requena, mmiozzo, ns-bugs |
| Priority: | P5 | ||
| Version: | pre-release | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | Patch | ||
Same comment applies to buildings module:
'test/buildings-pathloss-test.h',
'test/buildings-shadowing-test.h',
I assume that:
'test/lte-simple-net-device.h',
'test/lte-simple-helper.h',
can stay, but other don't seem very useful.
Hi Vedran, I agree that test headers should not be installed unless they are useful for some other module. Also lte-simple-net-device.h and lte-simple-helper.h are not meant to be used outside of the lte module, and if they really were meant to be used, they should be moved to src/lte/model instead. It seems however that it takes some effort to fix this, because of the many interdependencies among files in src/lte/test, the need to add some forward declarations, etc. I'll be able to work more on this issue tomorrow. changeset: 49d3a0979d43 user: Nicola Baldo <nbaldo@cttc.es> date: Tue May 29 13:56:26 2012 +0200 summary: fixed Bug 1439 - exclude headers for tests from installation Thanks Nicola. |
Created attachment 1402 [details] Patch Hi, modules other than lte don't install headers for tests. It would be great if lte did the same, unless there is a specific reason for doing otherwise.