|
Bugzilla – Full Text Bug Listing |
| Summary: | unimplemented LTE Scheduler methods | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Nicola Baldo <nicola> |
| Component: | lte | Assignee: | Nicola Baldo <nicola> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | moijes12, ns-bugs, tomh |
| Priority: | P5 | ||
| Version: | ns-3-dev | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: | Patch for this ticket. | ||
Created attachment 1476 [details]
Patch for this ticket.
Hi
I have created a patch. I hope this helps. This is my first contribution to NS-3 so suggestions are welcome.
Thanks for this patch! I just committed it and pushed to ns-3-dev. changeset: 9155:3a2efbb0e7d9 tag: tip user: moijes12@gmail.com date: Sat Dec 01 12:22:18 2012 +0100 summary: fixed bug 1532 - unimplemented LTE Scheduler methods |
This issue was raised for the GSoC 2012 code by Dizhi, but it also affects the pre-existing LTE scheduler implementations. On 11/14/2012 03:15 PM, Tom Henderson wrote: > > From my reading of it, there seem to be a few things to deal with: > > - decide which of your unimplemented API should be removed, raise log > warning, or error out if called No method should be removed, as they are all defined within the Femto Forum API. I've gone through the code, and I propose this solution. The following methods should trigger NS_FATAL_ERROR ("method not implemented"): DoCschedLcReleaseReq DoCschedUeReleaseReq DoSchedDlPagingBufferReq DoSchedDlMacBufferReq DoSchedDlRachInfoReq they are currently not used by the MAC, but, if they were used, one would expect some action to be taken. The following other methods are simple notifications, and hence they are allowed to be empty: DoSchedUlNoiseInterferenceReq DoSchedUlSrInfoReq this means that the current "TODO" comment should be removed.