Bug 1566

Summary: WiFi SNR tag improvements
Product: ns-3 Reporter: Tom Henderson <tomh>
Component: wifiAssignee: Nicola Baldo <nicola>
Status: RESOLVED FIXED    
Severity: enhancement CC: jonathan.ling77, nikkipui, ns-bugs, ruben
Priority: P5    
Version: pre-release   
Hardware: PC   
OS: Linux   
Attachments: patch existing code
snr-tag header
snr-tag implementation

Description Tom Henderson 2013-01-14 00:20:53 UTC 
Created attachment 1496 [details]
patch existing code

Copying over from ns-3-reviews, so we don't lose track of this.

Hi all,

I have noticed that the SNR tag is still embedded in mac-low.cc which makes it unusable for others.
Therefore, I have created this small patch to clean it a bit. This is based on the code in mac-low and the qos-tag.

Any comments are welcome. I will provide also some scenario examples to use it. 

Regards,
Konstantinos
Comment 1 Tom Henderson 2013-01-14 00:21:25 UTC 
Created attachment 1497 [details]
snr-tag header
Comment 2 Tom Henderson 2013-01-14 00:21:49 UTC 
Created attachment 1498 [details]
snr-tag implementation
Comment 3 Daniel L. 2013-02-10 13:47:34 UTC 
changeset: 9234:310d371059d5
Comment 4 Jonathan Ling 2013-07-12 14:56:55 UTC 
Konstantions,
Thanks!  Perhaps to mention the current usage is as a side-channel to get the received SNR to the sending node, but that we would also like to reuse tag upward.  For example: in mac-low.cc

rxPacket:
  WifiMacTrailer fcs;
  packet->RemoveTrailer (fcs);
  
  SnrTag tag; // to make receive SNR available at upper layers
  if (packet->PeekPacketTag(tag) == true)
    {
      packet->RemovePacketTag(tag);
    }
  tag.Set (rxSnr);  
 packet->AddPacketTag (tag);