|
Bugzilla – Full Text Bug Listing |
| Summary: | IP layer tracing is unavailable in the new helper API | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Rajib Bhattacharjea <raj.b> |
| Component: | samples | Assignee: | ns-bugs <ns-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | pre-release | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: |
patch to InternetStackHelper implementing IP layer tracing
Update to previous patch for "static" semantics |
||
Created attachment 121 [details]
patch to InternetStackHelper implementing IP layer tracing
Looks awesome but, for consistency, EnablePcap should be static and, once you have done this, the tcp example script should be updated to use the non-member method syntax. Created attachment 122 [details]
Update to previous patch for "static" semantics
Here is a slightly modified implementation with static function semantics instead of method semantics, i.e. InternetStackHelper::EnablePcap("tracefilename")
looks good to me. feel free to apply as this looks like a trivial addition. Pushed in ns-3-dev as: 2845:2398826af6b4 |
And Mathieu mentioned he envisions the PcapTrace being worked out of our code at some point in favor of a helper. The patch essentially copies the current PcapTrace functionality into InternetStackHelper, i.e. InternetStackHelper internet; internet.EnablePcap("traceName");