Bug 1617

Summary: Wrong SINR calculation
Product: ns-3 Reporter: Oleksandr <oleksandr.puchko>
Component: lteAssignee: Nicola Baldo <nicola>
Status: RESOLVED FIXED    
Severity: normal CC: mmiozzo, ns-bugs, tomh
Priority: P5    
Version: pre-release   
Hardware: PC   
OS: Linux   
Attachments: bug can be solved, by adding two lines of code

Description Oleksandr 2013-04-02 08:38:06 UTC
Created attachment 1550 [details]
bug can be solved, by adding two lines of code

I've found one small bug in the code, related to the SINR calculation. It is allocated in LteUePhy::CreateDlCqiFeedbackMessage. In the begining,  this function calculates average RSRP based on "sum" and "rbNum" and then calculates average SINR with the same variables without setting them to zero. 

I will not attach the patch, since it is only two line of code. However, you can found the diff file in the attachment.
Comment 1 Marco Miozzo 2013-04-09 04:50:50 UTC
Many thanks Oleksandr for the bug report, the bug has been solved in the lena-dev repository and Nicola is working for integrating it in the next ns3 release.
Comment 2 Nicola Baldo 2013-04-09 05:28:48 UTC
I've merged Marco's changes into the LTE module repository proposed for the merge with ns-3-dev for the upcoming ns-3.17 release 
http://code.nsnam.org/nbaldo/ns-3-lena-dev-merge-ns-3-dev+dizhi/
changeset: 17f49271f94f

I will close this issue once the fix gets into ns-3-dev.
Comment 3 Nicola Baldo 2013-04-30 09:29:30 UTC
the fix was included in ns-3-dev with the recent LENA merge