Bug 1634

Summary: NdiscCache use slightly bugged...
Product: ns-3 Reporter: Tommaso Pecorella <tommaso.pecorella>
Component: ipv6Assignee: Tommaso Pecorella <tommaso.pecorella>
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs
Priority: P5    
Version: ns-3-dev   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 1646    
Attachments: patch
This is the right patch. Sorry
Another try...

Description Tommaso Pecorella 2013-04-19 18:26:27 UTC
Created attachment 1566 [details]
patch

Nothing big, however...
1) It is created also for No-Arp interfaces, which is a resource waste,
2) Icmpv6L4Protocol isn't checking for its existence when performing a lookup, and
3) Icmpv6L4Protocol::Lookup doesn't return the Mac Address in some cases.

All the 3 points are fixed in the patch.
Comment 1 Tommaso Pecorella 2013-04-26 03:47:04 UTC
Created attachment 1568 [details]
This is the right patch. Sorry
Comment 2 Tommaso Pecorella 2013-04-26 03:51:40 UTC
Created attachment 1569 [details]
Another try...

Bugzilla seems to cut the patch file. Or it's my Mac ?
Comment 3 Tommaso Pecorella 2013-04-26 03:58:36 UTC
By the way, the rationale of this patch is this: there are some cases where the NdicCache is not created (i,e., for the loopback). Hence it's mandatory to check the cache existence, otherwise a dumb user (me) could try to look for it on the wrong interfaces.
This greatly simplifies the code and makes it easier to check for an NDISC entry on an unknown interface.
Comment 4 Tommaso Pecorella 2013-05-17 07:42:31 UTC
Fixed in changeset 9760 - 858d18e11e11