Bug 1785

Summary: Need destination and source mac addresses in MAC trace hooks
Product: ns-3 Reporter: Gustavo J. A. M. Carneiro <gjcarneiro>
Component: wifiAssignee: sebastien.deronne
Status: RESOLVED MOVED    
Severity: enhancement CC: ns-bugs, sebastien.deronne
Priority: P5    
Version: ns-3-dev   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 1645    
Attachments: patch

Description Gustavo J. A. M. Carneiro 2013-10-26 15:24:47 UTC
Created attachment 1688 [details]
patch

For fixing bug 1645, pyviz needs access to the addresses of the packet in MacTx and MacRx.  For completeness, the attached patch adds destination and source addresses to all the trace hooks, where applicable.
Comment 1 Daniel L. 2013-10-29 09:41:44 UTC
Hi Gustavo,

Thanks for the patch. I looked through it and the code is good. However, I'm not sure about the meaning of "source" and "destination" for NotifyXXX. Do you want to them to mean "transmitter and receiver" or "original source and destination"? I just want to check that they are correct.

Thanks,
Daniel
Comment 2 Gustavo J. A. M. Carneiro 2013-10-29 09:47:18 UTC
Hello.  What pyviz needs, at least, is the transmitter and receiver MAC stations.  If an AP is retransmitting a MAC frame from STA1 to STA2, I would like destination to be STA2.macaddr and source to be STA1.macaddr, even though the AP would be the actual transmitter.
Comment 3 Daniel L. 2013-10-29 10:05:16 UTC
Hi,

I see why you used GetAddr3() in some places.

One thing that I'm not sure is that I think most people would expect these kind of traces to show the immediate sender and receiver. (i.e. with AP, that would show AP address).
Comment 4 Gustavo J. A. M. Carneiro 2013-10-29 10:16:11 UTC
Hm.. ideally it would probably be better to just have the WifiMacHeader as parameter, but I'm not sure that is easy to obtain in all places...
Comment 5 sebastien.deronne 2020-04-12 09:19:07 UTC
Moved to https://gitlab.com/nsnam/ns-3-dev/-/issues/175