Bug 180

Summary:	Minor Error in UDP Echo Apps
Product:	ns-3	Reporter:	Joe Kopena <tjkopena>
Component:	samples	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	P4
Version:	pre-release
Hardware:	All
OS:	All

Description Joe Kopena 2008-05-16 04:02:26 UTC

UDPEchoClient::StopApplication, line 116, the "if (!m_socket)" should not be negated (looks copy & pasted from setup code).

Ditto UDPEchoServer::StopApplication, line 90.

The other applications seem fine.

Thx

Comment 1 Mathieu Lacage 2008-05-16 09:55:58 UTC

Generally, the code should be written as if (m_socket != 0) to avoid this kind of problem. i.e., avoid relying on implicit conversions.