Bug 1872

Summary: Inside RREQ processing, in case of IP duplication, packet dropped instead of being forwarded
Product: ns-3 Reporter: Tomasz Seweryn <tomasz.seweryn7>
Component: dsrAssignee: Yufei Cheng <michaelcheng1943>
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs, tommaso.pecorella
Priority: P3    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: Correction for RREQ packet processed improperly in dsr
Final correction

Description Tomasz Seweryn 2014-03-06 14:51:12 UTC 
During RREQ packet processing, in case of a node having route to the destination in its route cache, when there is a duplication of nodes in route collected until current node and route from route cache of current node, a packet is dropped instead of being forwarded.

Proper definition from RFC http://www.ietf.org/rfc/rfc4728.txt in the section 8.2.2. , last bullet on "[Page 68]":
"If the node does not return a cached Route Reply, then this node SHOULD transmit this copy of the packet as a link-layer broadcast (...)". 

In current form, algorithm works not in line with definition.
Proposed fix in the attachment.
Comment 1 Tomasz Seweryn 2014-03-06 14:55:45 UTC 
Created attachment 1794 [details]
Correction for RREQ packet processed improperly in dsr
Comment 2 Tomasz Seweryn 2014-03-11 13:10:44 UTC 
Created attachment 1799 [details]
Final correction

I'm terribly sorry, but previous bug fix is incorrect. I'm putting a correct one in this attachment.
Comment 3 Tommaso Pecorella 2014-05-02 10:38:43 UTC 
changeset:   10774:1f47a73ab755