Bug 1913

Summary: Crash in BlockAckManager::GetNextPacket when CleanupBuffers method actually deletes expired retry packets
Product: ns-3 Reporter: l.salameh
Component: wifiAssignee: Daniel L. <nikkipui>
Status: RESOLVED FIXED    
Severity: normal CC: l.salameh, ns-bugs, tomh
Priority: P5 Keywords: bug, patch
Version: ns-3.14   
Hardware: Mac Intel   
OS: Mac OS   
Attachments: Patch for crashes in BlockAckManager

Description l.salameh 2014-05-07 11:41:05 UTC
Created attachment 1838 [details]
Patch for crashes in BlockAckManager

When block acked data packets expire in the retry list of the BlockAckManager, the CleanupBuffers method actually deletes these packets
from the m_retryPackets list. On returning from that method, the caller
GetNextPacket attempts to access m_retryPackets.front(), which causes a crash if the retry packets list is now empty.


The fix is a one liner, very simple. See attached patch.
Comment 1 Tom Henderson 2014-05-30 02:01:15 UTC
fixed in changeset 10794:14430d46a1a6