|
Bugzilla – Full Text Bug Listing |
| Summary: | refactoring of lte-sinr-chunk-processor | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Nicola Baldo <nicola> |
| Component: | lte | Assignee: | Nicola Baldo <nicola> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | mmiozzo, ns-bugs |
| Priority: | P5 | ||
| Version: | ns-3-dev | ||
| Hardware: | PC | ||
| OS: | Linux | ||
sorry wrong files, the right ones are lte-sinr-chunk-processor.{h,cc}
There is also a lot of copy-paste in these files. It looks like that all this copy-paste is needed just to pass output to functions with different names, but that have all the same signature. Maybe we could refactor it to use a single class with a (list of?) callbacks to which the output is passed. This was fixed by Piotr as part of the GSoC 2014 FFR algorithms work (changeset 3e86fac77082) |
In src/lte/model/lte-interference.{h,cc}, the "Sinr" in XxxxxSinrChunkProcessor is in many case misnamed as it's not always SINR. The same applies for the m_sumSinr variable in many places, often it's not SINR. We should rename variables so the naming is consistent.