Bug 1954

Summary: Serialized size of wifi-net-device differ for TX and RX trace
Product: ns-3 Reporter: Matthias <donutcop>
Component: wifiAssignee: sebastien.deronne
Status: RESOLVED FIXED    
Severity: enhancement CC: ns-bugs, sebastien.deronne
Priority: P5    
Version: ns-3.20   
Hardware: All   
OS: All   
Attachments: diff -r da0eb48df23f src/wifi/model/wifi-net-device.cc
refactored patch

Description Matthias 2014-07-18 05:32:04 UTC
Created attachment 1855 [details]
diff -r da0eb48df23f src/wifi/model/wifi-net-device.cc

I wondered why the packet sizes for one packet differ for MacTx and MacRx trace of the WifiMac-Class. The reason is, that the Notification is done at "sender"-Side after adding the LLC-Header to the Packet and at "receiver"-Side after removing it. Actually the header should be removed after notifiying the LLC-Packet at receiver side. I attached a example patch for solving this issue.
Comment 1 sebastien.deronne 2015-10-04 16:43:55 UTC
Created attachment 2159 [details]
refactored patch

The order of operation is indeed not ok.
But I do not fully agree with the patch, llc header may be removed twice.

I changed a bit the proposed patch.
Comment 2 sebastien.deronne 2015-10-10 05:46:52 UTC
refactored patch committed in changeset 11686:aa661e60709e