Bug 2125

Summary:	Subclasses should chain up to their base class NotifyNewAggregate() method
Product:	ns-3	Reporter:	nlmills
Component:	general	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	tomh, tommaso.pecorella
Priority:	P5
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	Proposed patch

Description nlmills 2015-05-27 19:26:51 UTC

Classes that override Object::NotifyNewAggregate() "must chain up to their base class NotifyNewAggregate() method" according to the documentation. However, examples in the current code always invoke Object::NotifyNewAggregate() regardless of the actual base class.

Comment 1 nlmills 2015-05-27 19:33:17 UTC

Created attachment 2048 [details]
Proposed patch

Patch against d118c95b966c952258dc1db67832dfa5c6a44685

Comment 2 Tommaso Pecorella 2015-05-28 05:59:33 UTC

+1, even if it's mostly a stylistic problem.

Comment 3 Tom Henderson 2015-06-11 13:10:20 UTC

Yes, I put this on the ns-3.24 schedule.

Comment 4 Tom Henderson 2015-06-25 00:51:53 UTC

committed in changeset 11463:60d4486a863a