Bug 2249

Summary:	LTE perl speed tests possibly broken
Product:	ns-3	Reporter:	Tommaso Pecorella <tommaso.pecorella>
Component:	lte	Assignee:	Biljana Bojović <bbojovic>
Status:	RESOLVED FIXED
Severity:	minor	CC:	ns-bugs, tomh
Priority:	P5
Version:	pre-release
Hardware:	All
OS:	All
Attachments:	patch

Description Tommaso Pecorella 2015-12-26 13:13:20 UTC

The problem as been reported by Radhakrishnan Subramanian  here:
https://groups.google.com/forum/#!topic/ns-3-users/YylGW7NQQhY

To summarize it, epc-test-run-time.pl is broken.
There's a missing semicolon at line 17 (the one starting with "my $launch"), but there's more.
The output is blank, meaning that the time statistics aren't captured at all, making the script useless (unless fixed).

My perl skills are close to zero, and the fact that perl doesn't have an interactive shell or debugger isn't helping.
I suspect that it's a problem about how the time results are captured and parsed by perl.

Comment 1 Tommaso Pecorella 2015-12-26 13:23:53 UTC

I can confirm that the problem is also in lte-test-run-time.pl

the output is:
#sTime	nFloors	nEnb	nUe	rTime	rTDev
5	0	1	1	0	0
5	0	1	5	0	0
5	0	1	10	0	0
...

but rTime and rTDev should contain the the execution time average and standard deviation.

And since I just made it... here's the output of the upcoming tool to help the debuggers.

pecos@nightwatch ~/workspace/ns-3-allinone/ns-3-dev $ sh report.sh 
 ** System info **
Linux nightwatch 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
Linux Mint 17.2 Rafaela \n \l
 ** Compiler type and version **
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

 ** ns-3 version **
3-dev
changeset: 11797:838552e9d264 tag: tip user: Tom Henderson <tomh@tomh.org> date: Wed Dec 23 09:43:13 2015 -0800 summary: update CHANGES.html

Comment 2 Tommaso Pecorella 2015-12-28 11:53:21 UTC

Created attachment 2218 [details]
patch

Fix.

The problem is that "time" is both a bash command AND a standard linux command. Perl uses the standard linux command, whose syntax depends on environment variables. Unless explicitly forced to use a specific format :o

Comment 3 Tom Henderson 2016-01-04 14:37:28 UTC

Biljana, can you please test on your system and then commit the attached?  Thanks.

Comment 4 Biljana Bojović 2016-02-16 18:52:42 UTC

(In reply to Tom Henderson from comment #3)
> Biljana, can you please test on your system and then commit the attached? 
> Thanks.

Sorry for really late reply. I was on days off when all these follow ups were created. I will try it these days and let you know.

Thank you for your effort to solve this.

Comment 5 Biljana Bojović 2016-02-24 10:16:24 UTC

Patch works fine. I have tested both perl scripts and times are now properly written to the output file. 

Tommaso thank you very much for your contribution!

Comment 6 Tom Henderson 2016-02-24 12:30:59 UTC

pushed in changeset 11917:8699244abd55