|
Bugzilla – Full Text Bug Listing |
| Summary: | GSL not successfully enabled for WiFi DSSS error rate model | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Tom Henderson <tomh> |
| Component: | wifi | Assignee: | sebastien.deronne |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ns-bugs |
| Priority: | P5 | ||
| Version: | pre-release | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: |
patch to fix
regression test test program from validation document plotting program |
||
Created attachment 2228 [details]
regression test
regression test attached
Created attachment 2231 [details]
test program from validation document
The DSSS error rate program and plotting script could also be possibly added to the src/wifi/test directory. I scraped it out of the PDF, reformatted, added GPL, and attach it here.
Created attachment 2232 [details]
plotting program
The DSSS error rate program and plotting script could also be possibly added to the src/wifi/test directory. I scraped it out of the PDF, reformatted, added GPL, and attach it here.
I had a quick look, I am in favor to deliver those changes. Utests were indeed missing (as for a lot of other parts of the code, that I plan to cover as much as possible in the future), so this is a really nice-to-have. bugfix pushed in changeset 11817:908a1df3879d test programs pushed in changeset 11818:1df885710050 |
Created attachment 2227 [details] patch to fix Even if a platform has GSL installed, the preprocesser defines are wrong in the code, causing the non-GSL code to execute in all cases. Attached patch fixes the problem (ENABLE_* at configure time is changed to HAVE_* at build time). Will write a regression test for this before closing out.