Bug 2340

Summary:	RED incorrectly checks if there is enough room for a packet in byte mode
Product:	ns-3	Reporter:	Stefano Avallone <stavallo>
Component:	traffic-control	Assignee:	Stefano Avallone <stavallo>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	ns-bugs, tomh
Priority:	P5
Version:	pre-release
Hardware:	PC
OS:	Linux
Attachments:	Proposed fix

Description Stefano Avallone 2016-03-17 18:02:42 UTC

Created attachment 2345 [details]
Proposed fix

The check performed by the DoEnqueue method of RED to determine whether a packet exceeds its limit:

nQueued >= m_queueLimit

is incorrect if RED operates in byte mode and leads to RED not recognizing that the packet will be dropped by the internal DropTail queue.

Please see:

https://groups.google.com/forum/?fromgroups#!topic/ns-3-users/Ic8J_Owe68c

for more context.

Attached is a patch contributed by Mohit and Lynne that fixes this check.

Comment 1 Tom Henderson 2016-03-18 00:19:05 UTC

pushed in changeset 12055:1ef99429c15e