Bug 2445

Summary:	Out of bounds array access in MinstrelHtWifiManager::SetBestProbabilityRate
Product:	ns-3	Reporter:	Alexander Krotov <krotov>
Component:	wifi	Assignee:	sebastien.deronne
Status:	RESOLVED FIXED
Severity:	major	CC:	matis18, ns-bugs
Priority:	P3
Version:	ns-3.25
Hardware:	All
OS:	All
Attachments:	Proposed patch Patch proposed v2

Description Alexander Krotov 2016-06-20 09:10:25 UTC

group->m_maxProbRate is not converted to group index before using. It results in out of bounds read access:
http://code.nsnam.org/ns-3-dev/file/d44748d98fe6/src/wifi/model/minstrel-ht-wifi-manager.cc#l1433

Patch follows.

Comment 1 Alexander Krotov 2016-06-20 09:18:17 UTC

Created attachment 2476 [details]
Proposed patch

Comment 2 sebastien.deronne 2016-06-23 03:05:17 UTC

Matias, could you please have a look?

Comment 3 Matías Richart 2016-06-27 07:37:41 UTC

The patch is correct, there is an error there.
I modified the patch so as to use an existent variable.

Comment 4 Matías Richart 2016-06-27 07:38:10 UTC

Created attachment 2486 [details]
Patch proposed v2

Comment 5 sebastien.deronne 2016-06-28 16:34:53 UTC

ok for me

Comment 6 sebastien.deronne 2016-07-12 16:24:25 UTC

Final patch pushed in changeset 12187:c5db6c9be200