Bug 2446

Summary: Comma instead of pipe in Attributes
Product: ns-3 Reporter: Tommaso Pecorella <tommaso.pecorella>
Component: traffic-controlAssignee: Stefano Avallone <stavallo>
Status: RESOLVED FIXED    
Severity: trivial CC: ns-bugs, tomh
Priority: P5    
Version: ns-3-dev   
Hardware: All   
OS: All   
See Also: https://www.nsnam.org/bugzilla/show_bug.cgi?id=2447
Attachments: fix

Description Tommaso Pecorella 2016-06-22 17:54:09 UTC
Created attachment 2477 [details]
fix

In the traffic control examples it is used a wrong syntax, e.g.:
clientHelper.SetAttribute ("OnTime", StringValue ("ns3::UniformRandomVariable[Min=0.,Max=1.]"));

The correct field separator is |, not a comma.

It is worth noticing that also the attribute-test-suite contains the very same mistake.
Lucky enough, the call was setting the attribute value to its default value.

As a side note... is this mentioned in the documentation ?
Comment 1 Tom Henderson 2016-06-22 20:53:12 UTC
see also a similar problem with:

examples/tcp/tcp-nsc-lfn.cc:103
Comment 2 Stefano Avallone 2016-06-23 09:31:33 UTC
Thanks for spotting these mistakes. Please go ahead and commit the fix, thanks!
Comment 3 Tommaso Pecorella 2016-06-23 17:59:34 UTC
pushet in changeset 12168:b7d315126827