Bug 2450

Summary:	LogDistancePropagationLossModel is not continuous
Product:	ns-3	Reporter:	Tommaso Pecorella <tommaso.pecorella>
Component:	propagation	Assignee:	Nicola Baldo <nicola>
Status:	RESOLVED FIXED
Severity:	minor	CC:	ns-bugs
Priority:	P5
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	model behavior before patch model behavior after patch

Description Tommaso Pecorella 2016-07-12 19:30:55 UTC

The reference discussion is here:
https://groups.google.com/forum/#!topic/ns-3-users/bBEUYHwvZwU

Summarizing, LogDistancePropagationLossModel::DoCalcRxPower is not continuous when one reaches the minimum distance (minor nuisance, but still a nuisance).

Moreover, Krishna (the poster) also suggests to clarify if the units are in dBm or dB.

Comment 1 Nicola Baldo 2016-10-12 15:19:45 UTC

Created attachment 2611 [details]
model behavior before patch

Comment 2 Nicola Baldo 2016-10-12 15:20:28 UTC

Created attachment 2612 [details]
model behavior after patch

Comment 3 Nicola Baldo 2016-10-12 15:28:37 UTC

I've just fixed the discontinuity issue in changeset 4da9433a490d following Krishna's proposal, which I think made perfectly sense. See the attached figures for the change in model behavior. 

As for dBm vs dB: TX power is in dBm and gain values are in dB, and that's the way it should be. I think that the comments in the code and the doxygen documentation are already clear on this matter.