Bug 250

Summary:	Tcp breaks if you set the delackcount > 2
Product:	ns-3	Reporter:	Rajib Bhattacharjea <raj.b>
Component:	internet	Assignee:	Rajib Bhattacharjea <raj.b>
Status:	RESOLVED FIXED
Severity:	normal	CC:	craigdo, ns-bugs
Priority:	P1
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	simple fix

Description Rajib Bhattacharjea 2008-07-09 14:27:13 UTC

If you try to tell TCP to ack each third(4th, 5th, etc) packet instead of each second one, the code has a logical error preventing its correct operation.  This is TcpSocket attribute DelAckCount.

Offending code is lines 1129-1139 in http://code.nsnam.org/ns-3-dev/file/266c6a334762/src/internet-stack/tcp-socket-impl.cc

Comment 1 Rajib Bhattacharjea 2008-12-01 10:42:17 UTC

Created attachment 321 [details]
simple fix

Test case:
./waf --run="tcp-large-transfer --ns3::TcpSocket::DelAckCount=3"

Appears to work as proposed.

Comment 2 Rajib Bhattacharjea 2008-12-01 10:47:12 UTC

Patch looks good, reassigning to release manager.

Comment 3 Rajib Bhattacharjea 2008-12-03 11:20:24 UTC

Reassigned to myself.