Bug 2568

Summary:	Avoid enumerating TCP variants in examples
Product:	ns-3	Reporter:	Rohit P. Tahiliani <rohit.tahil>
Component:	examples	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	tomh
Priority:	P3
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	Proposed patch Proposed patch

Description Rohit P. Tahiliani 2016-12-04 14:12:20 UTC

Created attachment 2690 [details]
Proposed patch

As suggested by Tom Sir, I have attached a patch that makes use of

TypeId::LookupByNameFailSafe (std::string name, TypeId *tid)

in examples/tcp/tcp-variants-comparison.cc to avoid enumerating all TCP variants.

I will see if I can find more such programs which enumerate TCP variants, and update them. I did not find more in examples/tcp directory.

Any suggestions would be much appreciated.

Thanks,
Rohit P. Tahiliani

Comment 1 Rohit P. Tahiliani 2017-05-30 14:38:03 UTC

Created attachment 2856 [details]
Proposed patch

Comment 2 Rohit P. Tahiliani 2017-05-30 14:39:12 UTC

Hi Tom Sir,

I have uploaded a new patch based on the latest ns-3-dev. 

Thank you,
Rohit

Comment 3 Tom Henderson 2017-06-03 01:45:36 UTC

committed in changeset 12907:86f643f3d027