Bug 2596

Summary:	EthernetTrailer::GetFcs should be const
Product:	ns-3	Reporter:	debug.ito
Component:	network	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	tomh
Priority:	P3
Version:	pre-release
Hardware:	All
OS:	All

Description debug.ito 2016-12-24 03:23:35 UTC

This function doesn't have to be non-const at all. Being non-const compormises usability of this function.

Comment 1 Tom Henderson 2016-12-24 10:27:52 UTC

I agree, I will patch this if no other comments.

--- a/src/network/utils/ethernet-trailer.h	Thu Dec 22 23:20:55 2016 +0300
+++ b/src/network/utils/ethernet-trailer.h	Sat Dec 24 07:28:17 2016 -0800
@@ -67,7 +67,7 @@
   /**
    * \return the FCS contained in this trailer
    */
-  uint32_t GetFcs ();
+  uint32_t GetFcs () const;

Comment 2 Tom Henderson 2017-01-26 00:49:40 UTC

fixed in changeset bc8fbd146d50