Bug 278

Summary: Ipv4Header does not print the protocol number
Product: ns-3 Reporter: Mathieu Lacage <mathieu.lacage>
Component: networkAssignee: Kunal Kerkar <kunalkerkar>
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs, raj.b
Priority: P3    
Version: pre-release   
Hardware: All   
OS: All   

Description Mathieu Lacage 2008-08-09 13:26:05 UTC 
Printing the protocol number is going to change the output of all regression traces but it would be useful.
Comment 1 Mathieu Lacage 2008-08-09 13:27:02 UTC 
A patch would look roughly like that. Is anyone against that ?


diff -r fc07f91a5da1 src/node/ipv4-header.cc
--- a/src/node/ipv4-header.cc   Fri Aug 08 22:15:25 2008 -0700
+++ b/src/node/ipv4-header.cc   Sat Aug 09 10:37:07 2008 -0700
@@ -221,6 +221,7 @@ Ipv4Header::Print (std::ostream &os) con
   os << "tos 0x" << std::hex << m_tos << std::dec << " "
      << "ttl " << m_ttl << " "
      << "id " << m_identification << " "
+     << "protocol " << m_protocol << " "
      << "offset " << m_fragmentOffset << " "
      << "flags [" << flags << "] "
      << "length: " << (m_payloadSize + 5 * 4)
Comment 2 Tom Henderson 2008-08-10 13:25:28 UTC 
+1
Comment 3 Craig Dowell 2008-08-10 13:36:07 UTC 
+1
Comment 4 Mathieu Lacage 2008-10-20 07:33:30 UTC 
changeset a0946f209866