|
Bugzilla – Full Text Bug Listing |
| Summary: | Packets need metadata support for printing without header checking | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Mathieu Lacage <mathieu.lacage> |
| Component: | core | Assignee: | ns-bugs <ns-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | pre-release | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | add EnableChecking and EnablePrinting | ||
+1 +1 Created attachment 227 [details]
add EnableChecking and EnablePrinting
Packet::EnableMetadata is made deprecated. Packet::EnablePrinting allows you to call Packet::Print successfully. Packet::EnableChecking enables error checking. please, review. (In reply to comment #4) > Packet::EnableMetadata is made deprecated. Packet::EnablePrinting allows you to > call Packet::Print successfully. Packet::EnableChecking enables error checking. > > please, review. > I reviewed this patch and it looks good to me. changeset: 065488d0420c |
there are lots of cases where we want to enable the packet metadata to be able to print the content of the packet but where we don't want to enable the packet error checking. We could add the following functions: class Packet { public: static void EnableChecking (void); static void DisableChecking (void); }; the default would be no checking to be consistent with the "no metadata" default.