Bug 2865

Summary: Enable function, node, and time prefixes to LteHelper::EnableLogComponents()
Product: ns-3 Reporter: Tom Henderson <tomh>
Component: lteAssignee: Biljana Bojović <bbojovic>
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs
Priority: P3    
Version: unspecified   
Hardware: All   
OS: All   
Attachments: suggested patch
suggested patch v2

Description Tom Henderson 2018-02-06 18:30:51 UTC
Created attachment 3029 [details]
suggested patch

LteHelper::EnableLogComponents() turns on all logging in LTE.  Sample output:

LteInterference:ConditionallyEvaluateChunk(0x1030640)
0x1030640 now +2214285.0ns last +2214285.0ns

However, it is hard to follow anything without node, function, and time context.  With the attached patch, the above becomes:

0.00221428s 4 LteInterference:ConditionallyEvaluateChunk(0x1b78650)
0.00221428s 4 LteInterference:ConditionallyEvaluateChunk(): 0x1b78650 now +2214285.0ns last +2214285.0ns
Comment 1 Biljana Bojović 2018-02-08 02:17:13 UTC
Yes, you are right. I think that this is a very useful patch. 

Could you please proceed and push it? 

Thanks!
Comment 2 Tom Henderson 2018-02-08 19:42:50 UTC
(In reply to Biljana Bojović from comment #1)
> Yes, you are right. I think that this is a very useful patch. 
> 
> Could you please proceed and push it? 
> 
> Thanks!

There were many missing log components also (that method has not been updated in a while).  Do you agree also with the revised patch (all components, alphabetical by directory (model and helper)?
Comment 3 Tom Henderson 2018-02-08 19:43:22 UTC
Created attachment 3033 [details]
suggested patch v2
Comment 4 Tom Henderson 2018-03-06 00:40:39 UTC
fixed in 13393:a44383280cae