Bug 2871

Summary: uint128_t type not portable
Product: ns-3 Reporter: Tom Henderson <tomh>
Component: internetAssignee: Tommaso Pecorella <tommaso.pecorella>
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs
Priority: P3    
Version: unspecified   
Hardware: All   
OS: All   

Description Tom Henderson 2018-02-08 11:29:51 UTC 
changeset 13277 introduces use of uint128_t type to ipv6-address-helper.cc, but Robert reports that this type is not supported in Visual Studio.

One possibility is to rework the code to use struct in6_addr, or other refactoring...
Comment 1 Tommaso Pecorella 2018-02-08 11:53:00 UTC 
Not a big issue. I can use two uint64_t there.

However... what should we do with all the other places where uint128_t is used ?
Should we deprecate it ?

T.
Comment 2 Tom Henderson 2018-02-08 12:15:27 UTC 
(In reply to Tommaso Pecorella from comment #1)
> Not a big issue. I can use two uint64_t there.
> 
> However... what should we do with all the other places where uint128_t is
> used ?
> Should we deprecate it ?
> 
> T.

My scan of the codebase is that it is only used in the int64x64 code in core, but multiple implementations with a fallback if uint128_t is not available on the platform.  So I think we need to just fix it in the newly committed code.
Comment 3 Tommaso Pecorella 2018-02-08 20:04:20 UTC 
fixed in changeset:   13281:fcb5d90f5a27