Bug 2876

Summary: Do not shrink advWin when we already sent the FIN
Product: ns-3 Reporter: natale.patriciello
Component: tcpAssignee: natale.patriciello
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs
Priority: P3    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: Fixing the bug
Fix the bug + regression test

Description natale.patriciello 2018-02-16 10:31:30 UTC
Created attachment 3043 [details]
Fixing the bug

The current code check is in AdvertisedWindowSize is based on IsFinished() from TcpRxBuffer. It assumes that if we get the FIN, then IsFinished() returns true. However, the method checks also for any pending data; in case we send a FIN, then we have a retx timeout, we advertise a shrinked window.
Comment 1 natale.patriciello 2018-02-16 10:49:23 UTC
Created attachment 3044 [details]
Fix the bug + regression test

This patch contains also the regression test
Comment 2 natale.patriciello 2018-02-25 05:41:27 UTC
Fixed in 13328:ed34bc65af73