|
Bugzilla – Full Text Bug Listing |
| Summary: | Queue Disc drops the CE marked packets | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Vivek Jain <jain.vivek.anand> |
| Component: | internet | Assignee: | Tommaso Pecorella <tommaso.pecorella> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ns-bugs, stavallo, tahiliani.nitk, tomh |
| Priority: | P3 | ||
| Version: | ns-3-dev | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | Modified Mark method to return true when a packet has CE. | ||
After looking at what Linux does: https://elixir.bootlin.com/linux/latest/source/include/net/inet_ecn.h#L75 I agree with the proposed patch. Do you want me to push this patch on your behalf? Thanks. (In reply to Stefano Avallone from comment #1) > After looking at what Linux does: > > https://elixir.bootlin.com/linux/latest/source/include/net/inet_ecn.h#L75 > > I agree with the proposed patch. > > Do you want me to push this patch on your behalf? I agree to push this now; you can find Vivek's authorstring in the mercurial log. Pushed with changeset 13657:23cfc99011a6, thanks. |
Created attachment 3114 [details] Modified Mark method to return true when a packet has CE. Mark () method currently returns false for a packet that is already marked. This means that a queue disc would drop a marked packet (since it is not able to mark it). The attached patch resolves this issue. Mark () method has been modified to return true when a packet is already marked.