Bug 2964

Summary: IdealWifiManager keeps using the same MCS when all transmissions fail
Product: ns-3 Reporter: Alexander Krotov <krotov>
Component: wifiAssignee: sebastien.deronne
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs
Priority: P3    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: Proposed patch

Description Alexander Krotov 2018-07-27 05:58:29 UTC
Created attachment 3153 [details]
Proposed patch

When all transmissions of IdealWifiManager fail, for example
because the channel has degraded since last SNR estimation,
it keeps using the same MCS.

This patch makes it reset SNR to 0.0, so it starts using lowest MCS,
successfully transmits, and receives new correct estimation.

I changed ::DoReportFinalRtsFailed and ::DoReportFinalDataFailed.

Note that there is no need to change ::DoReportAmpduTxStatus, because it means Block ACK has been successfully received.
Comment 1 sebastien.deronne 2018-07-29 08:46:17 UTC
It looks ok for me.
If also fine for Tom who has better knowledge about ideal wifi manager, it can be pushed.
Comment 2 Alexander Krotov 2018-08-06 11:49:18 UTC
Pushed in changeset https://code.nsnam.org/index.cgi/ns-3-dev/rev/b5d73628dc6e

> If also fine for Tom who has better knowledge about ideal wifi manager, it can be pushed.

There are no objections for a week so I assume it is ok. If it causes any problems it is easier to revert.