Bug 2974

Summary:	Inconsistent declaration of IPV6 methods
Product:	ns-3	Reporter:	Zoraze Ali <zorazeali>
Component:	lte	Assignee:	Biljana Bojović <bbojovic>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ns-bugs, tomh
Priority:	P3
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	Patch LTE python bindings patch

Description Zoraze Ali 2018-08-21 08:29:52 UTC

I have noticed that the functions, "AssignUeIpv6Address" and "GetUeDefaultGatewayAddress6" are locally defined in EmuEpcHelper and PointToPointEpcHelper classes, rather than inheriting them from EpcHelper class.

Therefore, for the sake of consistency, these functions should be declared as pure virtual in EpcHelper class, and EmuEpcHelper and PointToPointEpcHelper classes can override them.

Kind regards,
Zoraze

Comment 1 Zoraze Ali 2018-08-21 08:32:18 UTC

Created attachment 3161 [details]
Patch

Comment 2 Zoraze Ali 2018-08-21 08:35:46 UTC

Created attachment 3162 [details]
LTE python bindings patch

This patch updates the LTE python bindings after applying the first patch.

Comment 3 Tom Henderson 2018-08-26 09:51:50 UTC

pushed in changeset 13753:af66aff96a95