Bug 2995

Summary:	Add structs for the parameters of TxOpportunity and ReceivePdu
Product:	ns-3	Reporter:	Zoraze Ali <zorazeali>
Component:	lte	Assignee:	Biljana Bojović <bbojovic>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	ns-bugs
Priority:	P3
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	enhancement patch

Description Zoraze Ali 2018-10-01 04:16:26 UTC

Created attachment 3189 [details]
enhancement patch

Hi,

This enhancement would introduce structs for the parameters of NotifyTxOpportunity and ReceivePdu methods in lte-mac-sap.h. This is the same logic as used for LteMacSapProvider::ReportBufferStatusParameters and LteMacSapProvider::TransmitPduParameters. 

It will make it possible to introduce more parameters easily without stuffing them individually into the NotifyTxOpportunity and ReceivePdu functions declarations.

The patch is created on top of the changeset 13809:cb31a3f56a28

Kind regards,
Zoraze

Comment 1 Biljana Bojović 2018-10-01 04:25:48 UTC

I agree, this enhancement will facilitate future addition of the parameters to these two functions, and will also allow easier manipulation with existing parameters.

Comment 2 Zoraze Ali 2018-10-02 09:11:31 UTC

Hi Biljana,

Thanks for reviewing it. 

Pushed in changeset 13814:637cc8ebb9fa

Kind regards,
Zoraze