|
Bugzilla – Full Text Bug Listing |
| Summary: | CSMA Devices should default to DIX not LLC encapsulation. | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Craig Dowell <craigdo> |
| Component: | devices | Assignee: | Craig Dowell <craigdo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ns-bugs |
| Priority: | P1 | ||
| Version: | ns-3.1 | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
Craig Dowell
2008-08-29 19:30:32 UTC
I am not sure about this attribute:
static const uint16_t DEFAULT_PAYLOAD_LENGTH = 1500;
.AddAttribute ("PayloadLength",
"The max PHY-level payload length of packets sent over this device.",
UintegerValue (DEFAULT_PAYLOAD_LENGTH),
I think it may be clearer to either support an attribute called "FrameSize" and make it default to 1518, or else eliminate this attribute entirely and make the MTU setting govern everything. As it is now, when moving the default encapsulation to DIX, this attribute and the default MTU will be the same.
(it may be that the simplest from a user perspective is to just support SetMTU and have the frame size be derived from the sum of the MTU plus layer-2 headers)
We should also plan about what we will do when we get to supporting VLANs. It will require a new encapsulation type and probably some more API to control the tag setting.
Preliminaries done. Just need to flip the switch and regenerate reference traces. |