|
Bugzilla – Full Text Bug Listing |
| Summary: | ip checksum calculation is disabled | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Mathieu Lacage <mathieu.lacage> |
| Component: | core | Assignee: | ns-bugs <ns-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P1 | ||
| Version: | pre-release | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: |
Add ipv4 checksum support.
Add ipv4 header checksum support. |
||
|
Description
Mathieu Lacage
2007-06-01 09:09:37 UTC
Created attachment 146 [details]
Add ipv4 checksum support.
Adds a static Checksum method to the ipv4 header class. Note that it only handles 20 byte ipv4 headers.
Created attachment 147 [details]
Add ipv4 header checksum support.
Essentially the same as the previous version, but this one will handle an ipv4 header with options, too.
I tried to re-use src/internet-node/ipv4-checksum.cc, but first
moving the header data from Buffer::Iterator to a temporary copy
so it can be fed to the existing code is almost as much code as
doing the checksumming right away.
looks good to me. can commit as-is. there's also this line in the header file that needs fixed: * \brief Enable checksum calculation for IP (XXX currently has no effect) also, should this m_calcChecksum value be integrated into the attribute system? (In reply to comment #4) > also, should this m_calcChecksum value be integrated into the attribute system? One way to integrate this in the attribute system would be to move this variable to the Ipv4L3Protocol object and make Ipv4Header::m_calcChecksum a non-static variable and set it based on the Ipv4L3Protocol::m_calcChecksum value. changeset: aabbcb2cba71 |