Bug 352

Summary:	Wifi STA mac address problems
Product:	ns-3	Reporter:	Gustavo J. A. M. Carneiro <gjcarneiro>
Component:	devices	Assignee:	Mathieu Lacage <mathieu.lacage>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ns-bugs
Priority:	P3
Version:	ns-3.2
Hardware:	All
OS:	All
Attachments:	patch to fix it foo

Description Gustavo J. A. M. Carneiro 2008-09-17 13:33:28 UTC

In Wifi infrastructure more:
1. STA X sends a broadcast
2. AP Y retransmits the broadcast for all nodes to receive
3. STA X receives the retransmission and receives it

Step 3 is bad, the STA should not forward to the upper layers broadcasts that it has sent.

Comment 1 Gustavo J. A. M. Carneiro 2008-09-17 13:34:19 UTC

Created attachment 258 [details]
patch to fix it

Comment 2 Mathieu Lacage 2008-10-16 04:49:34 UTC

I would suggest to check for hdr->GetAddr3 () from the caller rather than from the callee. i.e., ForwardUp should not be doing the address check. Its caller should.

Comment 3 Gustavo J. A. M. Carneiro 2008-10-16 06:15:42 UTC

OK, but that would mean changing the signature of ForwardUp to include a new address argument.

Comment 4 Mathieu Lacage 2008-10-16 06:27:55 UTC

Created attachment 265 [details]
foo

please, test the attached.

Comment 5 Gustavo J. A. M. Carneiro 2008-10-16 06:45:27 UTC

Comment on attachment 265 [details]
foo

It fixes the bug.

Comment 6 Mathieu Lacage 2008-10-16 06:47:28 UTC

changeset d26d57ddf801