|
Bugzilla – Full Text Bug Listing |
| Summary: | allinone download.py should probably not download NSC to OS X | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Tom Henderson <tomh> |
| Component: | build system | Assignee: | Gustavo J. A. M. Carneiro <gjcarneiro> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ns-bugs |
| Priority: | P5 | ||
| Version: | ns-3-dev | ||
| Hardware: | Mac Intel | ||
| OS: | Mac OS | ||
| Attachments: | proposed patch | ||
Created attachment 350 [details]
proposed patch
Comment on attachment 350 [details]
proposed patch
Looks good. Although I usually use sys.platform == 'darwin'; it's simpler.
Committed slightly modified patch. |
# # Get NSC # OS X HFS+ (case preserving, case insensitive) seems to have issue with the NSC code, when I run download.py Required NSC version: nsc-0.5.0 Retrieving nsc from https://secure.wand.net.nz/mercurial/nsc => hg clone https://secure.wand.net.nz/mercurial/nsc nsc requesting all changes adding changesets adding manifests adding file changes added 270 changesets with 17375 changes to 14991 files abort: case-folding collision between linux-2.6.26/include/linux/netfilter/xt_tcpmss.h and linux-2.6.26/include/linux/netfilter/xt_TCPMSS.h Traceback (most recent call last): File "./download.py", line 184, in <module> sys.exit(main()) File "./download.py", line 179, in main get_nsc(ns3_dir) File "./download.py", line 162, in get_nsc nsc_clone() File "./download.py", line 140, in nsc_clone run_command(['hg', 'clone', constants.NSC_REPO, constants.LOCAL_NSC_PATH]) File "/scratch/hg/gjc/ns-3-allinone/util.py", line 24, in run_command raise CommandError("Command %r exited with code %i" % (argv, retval)) util.CommandError: Command ['hg', 'clone', 'https://secure.wand.net.nz/mercurial/nsc', 'nsc'] exited with code 255 probably we should suppress the download of NSC on OS X and print out a notification to the user that it was skipped due to compatibility issues