Bug 526

Summary: PointToPointNetDevice::PhyTxBegin upcalls with an empty packet
Product: ns-3 Reporter: Rajib Bhattacharjea <raj.b>
Component: devicesAssignee: Craig Dowell <craigdo>
Status: RESOLVED FIXED    
Severity: normal CC: ns-bugs
Priority: P1    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: Trivial Fix?

Description Rajib Bhattacharjea 2009-03-22 15:54:05 UTC 
bool
PointToPointNetDevice::TransmitStart (Ptr<Packet> p)
{
  NS_LOG_FUNCTION (this << p);
  NS_LOG_LOGIC ("UID is " << p->GetUid () << ")");

  //
  // This function is called to start the process of transmitting a packet.
  // We need to tell the channel that we've started wiggling the wire and
  // schedule an event that will be executed when the transmission is complete.
  //
  NS_ASSERT_MSG(m_txMachineState == READY, "Must be READY to transmit");
  m_txMachineState = BUSY;
  m_phyTxBeginTrace (m_currentPkt);
  m_currentPkt = p;



It seems to me that the order of those last two lines needs to be switched, else the upcall is made with nonsense or with a null packet pointer.  Craig?
Comment 1 Rajib Bhattacharjea 2009-03-22 23:56:14 UTC 
Created attachment 400 [details]
Trivial Fix?
Comment 2 Craig Dowell 2009-03-23 14:42:19 UTC 
5854cddf4493