Bug 528

Presently, the Names::Add() and Names::Rename() methods return false with a soft failure in many cases if the naming attempt did not succeed (e.g. trying to Rename an object for which there is no existing name) and return true upon success.  This is not lined up with how our Config API works (where configuration failures are hard failures, and we provide a "FailSafe" variant of some methods if needed that will return false and not assert if there is a failure).

It seems to me that we ought to align these methods with previous convention that we avoid soft configuration failures.  FailSafe variants or helpers can be added in the future as needed.

I propose to fix this now for ns-3.4 since this is not yet released API.  Specifically, the proposal would be:

Names::Add() and Names::Rename() methods return type void, and assert where they previously returned false.