Bug 690

Summary:	tcp-nsc-lfn.cc is broken beyond repair
Product:	ns-3	Reporter:	Mathieu Lacage <mathieu.lacage>
Component:	samples	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tomh
Priority:	P5
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	remove cwnd tracing code

Description Mathieu Lacage 2009-09-28 04:38:05 UTC

this code appears to assume that the m_cwnd variable defined in NscTcpSocketImpl is actually a meaningful variable. 

It is not. I can't believe how broken this is. We should remove _at least_ the tracing part from that example file.

Comment 1 Tom Henderson 2010-01-13 00:18:54 UTC

(In reply to comment #0)
> this code appears to assume that the m_cwnd variable defined in
> NscTcpSocketImpl is actually a meaningful variable. 
> 
> It is not. I can't believe how broken this is. We should remove _at least_ the
> tracing part from that example file.

the attached patch removes that part of the example, without changing program behavior.

A bigger issue (not fixed for the moment) is to write a test suite that exercises/tests the socket and attribute API when NSC is used.

Comment 2 Tom Henderson 2010-01-13 00:19:24 UTC

Created attachment 720 [details]
remove cwnd tracing code

Comment 3 Tom Henderson 2010-01-16 17:02:05 UTC

changeset c64c692147f6