Bug 716

Summary:	Copy&Paste error? nsc/sysctl.c for 2.6.18 and 2.6.26, NS-3 3.5.1
Product:	nsc	Reporter:	Joerg <joerg.wagner>
Component:	Linux	Assignee:	Sam Jansen <sam.jansen>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fw-ns3
Priority:	P5
Version:	unspecified
Hardware:	All
OS:	All

Description Joerg 2009-10-13 05:03:08 UTC

linux-2.6.26/nsc/sysctl.c

{ "net.ipv4.ipfrag_time", { CTL_NET, NET_IPV4, NET_IPV4_IPFRAG_LOW_THRESH },
                                                               ^^^^^^^^^^
Shouldn't it read NET_IPV4_IPFRAG_TIME here?

Similar line appears in linux-2.6.18/nsc/sysctl.c.

Comment 1 Sam Jansen 2009-10-13 15:17:48 UTC

You're probably right. I'll try and have a look this week.

Alternatively, feel free to send a patch. Mercurial repository link is at http://research.wand.net.nz/software/nsc.php.

Adding Florian, incase he is interested.

Comment 2 Florian Westphal 2009-10-13 16:36:28 UTC

right, it should be NET_IPV4_IPFRAG_TIME.
Looking back I should have sticked with the /proc wrapper code 8-/

Comment 3 Sam Jansen 2009-10-21 14:46:38 UTC

Fixed in the NSC repo.