Bug 729

Summary: IPv6 over PPP
Product: ns-3 Reporter: Fabian Mauchle <f1mauchl>
Component: devicesAssignee: ns-bugs <ns-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: vincent
Priority: P4    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: patch
patch (replaces old one)

Description Fabian Mauchle 2009-10-22 05:13:23 UTC
Created attachment 636 [details]
patch

IPv6 can currently not communicate over a Point-to-Point link because its header has a hardcoded protocol value for IPv4.

The patch adds a protocol field to the Point-to-Point-Header and some methods to convert between PPP- and Ethernet- protocol numbers.
Comment 1 Sebastien Vincent 2009-10-22 07:51:55 UTC
Patch looks good.

Some (very very) minor comments:
- According to our naming convention: PPPtoETHER -> PppToEther and ETHERtoPPP -> EtherToPpp;
- \param and \return doxygen for PppToEther and EtherToPpp methods;
- Doxygen for m_protocol member.

(In reply to comment #0)
> Created an attachment (id=636) [details]
> patch
> 
> IPv6 can currently not communicate over a Point-to-Point link because its
> header has a hardcoded protocol value for IPv4.
> 
> The patch adds a protocol field to the Point-to-Point-Header and some methods
> to convert between PPP- and Ethernet- protocol numbers.
> 

Comment 2 Fabian Mauchle 2009-10-22 08:47:41 UTC
Created attachment 637 [details]
patch (replaces old one)

Minor changes requested by Sebastien
Comment 3 Sebastien Vincent 2009-11-12 03:24:26 UTC
Merge in revision c305c6e122c9