Bug 922

Summary: Inconsistent declaration of class/struct in wifi-remote-station-manager.h
Product: ns-3 Reporter: Quincy Tse <quincy.tse>
Component: wifiAssignee: Nicola Baldo <nicola>
Status: RESOLVED FIXED    
Severity: trivial CC: ns-bugs
Priority: P5    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: Proposed patch.
Proposed patch.

Description Quincy Tse 2010-05-27 20:16:02 UTC
Created attachment 889 [details]
Proposed patch.

Inconsistent declaration of the following as class/struct triggering static analysis warnings. No actual functional deficiencies.

debug/ns3/wifi-remote-station-manager.h:438:1: error: struct
      'WifiRemoteStationState' was previously declared as a class
      [-Wmismatched-tags]
struct WifiRemoteStationState
^~~~~~
class
debug/ns3/wifi-remote-station-manager.h:35:7: note: previous use is here
class WifiRemoteStationState;
      ^
debug/ns3/wifi-remote-station-manager.h:461:1: error: struct
      'WifiRemoteStation' was previously declared as a class
      [-Wmismatched-tags]
struct WifiRemoteStation
^~~~~~
class
debug/ns3/wifi-remote-station-manager.h:34:7: note: previous use is here
class WifiRemoteStation;

debug/ns3/wifi-remote-station-manager.h:463:3: error: struct
      'WifiRemoteStationState' was previously declared as a class
      [-Wmismatched-tags]
  struct WifiRemoteStationState *m_state;
  ^~~~~~
  class
debug/ns3/wifi-remote-station-manager.h:35:7: note: previous use is here
class WifiRemoteStationState
Comment 1 Quincy Tse 2010-05-27 21:14:09 UTC
Created attachment 890 [details]
Proposed patch.

Sorry, last proposed patch was bad.
Comment 2 Nicola Baldo 2010-06-07 10:34:17 UTC
changeset:   6339:84cbcc1a3f16

the changes that I implemented are slightly different than yours, please let me know if they are ok for you or you still have some problems.
Comment 3 Quincy Tse 2010-06-07 20:46:28 UTC
Thanks. Happy with the change (I forgot C++ doesn't need the keyword struct/class except for the class/struct definition).