Bug 1122 – spectrum-value test should check tolerance on a per-value basis

Bug 1122 - spectrum-value test should check tolerance on a per-value basis


Summary:	spectrum-value test should check tolerance on a per-value basis

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	spectrum
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 minor
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-05-03 05:56 UTC by Nicola Baldo
Modified:	2011-05-03 06:27 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nicola Baldo 2011-05-03 05:56:56 UTC

The spectrum-value test checks if two SpectrumValue instances match by testing the norm of the difference between the two spectrum values against a tolerance. This is not appropriate because the effect of the tolerance is proportional to the norm, which gets larger as the number of elements in the SpectrumValue (i.e., the number of bands in the SpectrumModel being used) get larger.

The correct behavior is to test equality within tolerance on a per-element basis.

Comment 1 Nicola Baldo 2011-05-03 06:27:41 UTC

changeset:   7124:058f6ecace0c
tag:         tip
user:        Nicola Baldo <nbaldo@cttc.es>
date:        Tue May 03 12:26:55 2011 +0200
summary:     fixed Bug 1122 - spectrum-value test should check tolerance on a per-value basis