Bug 1143 – CsmaStarHelper::GetHubDevices() returns spoke devices, not hub devices

Bug 1143 - CsmaStarHelper::GetHubDevices() returns spoke devices, not hub devices


Summary:	CsmaStarHelper::GetHubDevices() returns spoke devices, not hub devices

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	helpers
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-05-13 12:26 UTC by Shane Tuohy
Modified:	2011-08-09 16:20 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Fix for bug, replaces m_spokeDevices with m_hubDevices (359 bytes, patch) 2011-05-13 12:26 UTC, Shane Tuohy	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Shane Tuohy 2011-05-13 12:26:06 UTC

Created attachment 1113 [details]
Fix for bug, replaces m_spokeDevices with m_hubDevices

Title says it all, the problem is shown below. This is my first bug/fix submission, so if I have made a mistake, please let me know.

NetDeviceContainer
CsmaStarHelper::GetHubDevices () const
{ 
  return m_spokeDevices;
}

NetDeviceContainer
CsmaStarHelper::GetSpokeDevices () const
{ 
  return m_spokeDevices;
}


Fix diff is attached

Comment 1 John Abraham 2011-05-16 12:50:21 UTC

(In reply to comment #0)
> Created attachment 1113 [details]
> Fix for bug, replaces m_spokeDevices with m_hubDevices
> 
> Title says it all, the problem is shown below. This is my first bug/fix
> submission, so if I have made a mistake, please let me know.
> 
> NetDeviceContainer
> CsmaStarHelper::GetHubDevices () const
> { 
>   return m_spokeDevices;
> }
> 
> NetDeviceContainer
> CsmaStarHelper::GetSpokeDevices () const
> { 
>   return m_spokeDevices;
> }
> 
> 
> Fix diff is attached

The following changeset ought to address this
http://code.nsnam.org/ns-3-dev/rev/08ae7db938f6